DPL raw proxy: Supporting message sequences/pruned headers#7914
Merged
matthiasrichter merged 3 commits intoJan 8, 2022
Merged
Conversation
ktf
reviewed
Jan 7, 2022
ktf
reviewed
Jan 7, 2022
Member
There was a problem hiding this comment.
I would invert the logic and have a continue on channelName.empty() == true.
Collaborator
Author
There was a problem hiding this comment.
ah, yeah, can revise the logic. Actually I did not want to continue in the loop because the unmatched specs are logged. But I will combine this, there is room for cleanup in the logic.
This is also simplifying the message processing loop to avoid repeated query matching for split payload message pairs. Extending configuration of DPL injector function, but new configuration features like `paranoid` checking of message consistency still need to be implemented. Time consuming consistency checks are will be optional.
Having now a flexible message generation to test both split payload pair messages as well as payload sequences with one preceding header. Randomized test packages and enhanced check on the consumer side. Message mode is randomly selected per event.
The output proxy is not yet supporting forwarding of neither message pairs nor sequences, this needs to be investigated. Looks like not all parts are forwarded. The output proxy is based on message forwarding in the core framework DataProcessingDevice [480102:checker]: [08:58:09][ERROR] inconsistent number of inputs extracted [480102:checker]: [08:58:09][ERROR] inconsistent number of inputs extracted [480102:checker]: [08:58:09][ERROR] Header is not a DataHeader? [480102:checker]: [08:58:09][INFO] 1 input slots(s), data 0, parts 6, mode 1 [480102:checker]: [08:58:09][FATAL] Test condition "data == *counter" failed
matthiasrichter
force-pushed
the
dev-ExternalFairMQDeviceProxy
branch
from
fc6452f to
71707de
Compare
matthiasrichter
changed the title
Collaborator
Author
|
I think we simply go on with that now and I'm solving the minor cleanups in subsequent commits. |
Member
|
Yes, sure. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is following up to #7110 and O2 1325
More tests are ongoing right now and there is an issue with the message forwarding in the output proxy.